Оффлайн
- Регистрация
- 1 Мар 2015
- Сообщения
- 1,481
- Баллы
- 155
We deprecated "listings" in late 2023 with notice that this would be eventually removed from the codebase, and this is an update that it has been.
posted on
What type of PR is this? (check all applicable)
Deletes the ListingCategory model, factories, and specs. Guts the Listing model, removing almost all logic. Deletes associated factories, specs, search serializers, worker, and other dependencies. Modifies API specs/concerns to remove dependencies. Leaves only the API controller/route stubs and minimal Listing model structure intact.
Related Tickets & Documents
Please replace this line with instructions on how to test your changes, a note on the devices and browsers this has been tested on, as well as any relevant images for UI changes.
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
For more info, check out the .
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
[optional] What gif best describes this PR or how it makes you feel?
This was a goal in refining the functionality of Forem to more powerful and robust building blocks. Listing-like functionality can be achieved through posts/billboards/pages. We look forward to investing in those features to potentially host listing-like functionality, but for now it is a good thing for the codebase to remove.
Docs still may refer to listings, but we'll be looking to get docs more fully up-to-date soon.
posted on
What type of PR is this? (check all applicable)
- [x] Refactor
- [ ] Feature
- [ ] Bug Fix
- [ ] Optimization
- [ ] Documentation Update
Deletes the ListingCategory model, factories, and specs. Guts the Listing model, removing almost all logic. Deletes associated factories, specs, search serializers, worker, and other dependencies. Modifies API specs/concerns to remove dependencies. Leaves only the API controller/route stubs and minimal Listing model structure intact.
Related Tickets & Documents
- Related Issue #
- Closes # Closes #21624
Please replace this line with instructions on how to test your changes, a note on the devices and browsers this has been tested on, as well as any relevant images for UI changes.
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
- [ ] Semantic HTML implemented?
- [ ] Keyboard operability supported?
- [ ] Checked with and addressed Critical and Serious issues?
- [ ] Color contrast tested?
For more info, check out the .
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
- [x]
- [ ] No, and this is why: please replace this line with details on why tests have not been included
- [ ] I need help with writing tests
[optional] What gif best describes this PR or how it makes you feel?
This was a goal in refining the functionality of Forem to more powerful and robust building blocks. Listing-like functionality can be achieved through posts/billboards/pages. We look forward to investing in those features to potentially host listing-like functionality, but for now it is a good thing for the codebase to remove.
Docs still may refer to listings, but we'll be looking to get docs more fully up-to-date soon.